Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panic in to_physical for series of arrays and lists #21289

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

JakubValtar
Copy link
Contributor

This PR adds rechunking in ArrayChunked::to_physical_repr and ListChunked::to_physical_repr when needed.

Fixes #21285

The test depends on the Null field causing rechunking and should be removed or updated if that behavior changes.

@JakubValtar JakubValtar changed the title fix: panic in to_physical for series of arrays and lists fix: Panic in to_physical for series of arrays and lists Feb 16, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Feb 16, 2025
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.83%. Comparing base (5e51218) to head (87ca5ab).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21289   +/-   ##
=======================================
  Coverage   79.82%   79.83%           
=======================================
  Files        1596     1596           
  Lines      228565   228575   +10     
  Branches     2608     2608           
=======================================
+ Hits       182462   182476   +14     
+ Misses      45507    45503    -4     
  Partials      596      596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Thanks!

@ritchie46 ritchie46 merged commit 8978e18 into pola-rs:main Feb 17, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in to_physical for series of arrays and lists of specific types
2 participants