fix(python): Account for minor change in new connectorx release
#21277
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
c-peters,
MarcoGorelli and
reswqa
as code owners
alexander-beedie
added
ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21277 +/- ##
==========================================
+ Coverage 79.82% 79.89% +0.07%
==========================================
Files 1596 1596
Lines 228517 228519 +2
Branches 2608 2608
==========================================
+ Hits 182413 182578 +165
+ Misses 45508 45345 -163
Partials 596 596 ☔ View full report in Codecov by Sentry. |
|
Ah, you're on it! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
connectorxrelease (~8 hours ago) has removed the "arrow2" return type, and just uses "arrow" now (note that - amusingly - we don't use the "polars" return type directly as we want to applyschema_overridesourselves).This fixes the two tests that now fail in CI when
connectorxv0.4.2 is picked up.