Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly implement and test Skip Batch Predicate #21269

Merged

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Feb 14, 2025

This fixes a regression that caused us to not skip row groups sometimes.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 14, 2025
@coastalwhite coastalwhite force-pushed the chore/test-skip-batch-predicate branch from 330d350 to 01ffd65 Compare February 14, 2025 15:22
@coastalwhite coastalwhite marked this pull request as draft February 14, 2025 17:05
@coastalwhite

This comment was marked as resolved.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (1e16f14) to head (402830a).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...ars-plan/src/plans/aexpr/predicates/column_expr.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21269      +/-   ##
==========================================
+ Coverage   79.80%   79.89%   +0.08%     
==========================================
  Files        1596     1596              
  Lines      228489   228517      +28     
  Branches     2607     2608       +1     
==========================================
+ Hits       182355   182580     +225     
+ Misses      45538    45341     -197     
  Partials      596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite marked this pull request as ready for review February 14, 2025 17:50
@coastalwhite coastalwhite merged commit 947dc07 into pola-rs:main Feb 14, 2025
29 checks passed
@coastalwhite coastalwhite deleted the chore/test-skip-batch-predicate branch February 14, 2025 17:53
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants