-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Properly implement and test Skip Batch Predicate #21269
Merged
coastalwhite
merged 8 commits into
pola-rs:main
from
coastalwhite:chore/test-skip-batch-predicate
Feb 14, 2025
Merged
fix: Properly implement and test Skip Batch Predicate #21269
coastalwhite
merged 8 commits into
pola-rs:main
from
coastalwhite:chore/test-skip-batch-predicate
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
330d350
to
01ffd65
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21269 +/- ##
==========================================
+ Coverage 79.80% 79.89% +0.08%
==========================================
Files 1596 1596
Lines 228489 228517 +28
Branches 2607 2608 +1
==========================================
+ Hits 182355 182580 +225
+ Misses 45538 45341 -197
Partials 596 596 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression that caused us to not skip row groups sometimes.