Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deadlock due to bad logic in new-streaming join sampling #21265

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 14, 2025

I introduced early stopping during the cached morsel flushing but this wasn't correct. I also didn't correctly re-label the sequence ids leading to potentially the same morsel id being sent into multiple pipelines.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 14, 2025
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (9077aa4) to head (8503961).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 89 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21265      +/-   ##
==========================================
- Coverage   79.87%   79.86%   -0.01%     
==========================================
  Files        1596     1596              
  Lines      228469   228474       +5     
  Branches     2607     2607              
==========================================
- Hits       182487   182481       -6     
- Misses      45386    45397      +11     
  Partials      596      596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 7f0bfa1 into pola-rs:main Feb 14, 2025
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants