Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Don't mutate arena by default in Rewriting Visitor #21234

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 13, 2025
@ritchie46 ritchie46 merged commit a0e4651 into main Feb 13, 2025
21 checks passed
@ritchie46 ritchie46 deleted the treewalk branch February 13, 2025 13:39
Copy link
Contributor

The uncompressed lib size after this PR is 39.7782 MB.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (ed19c73) to head (b85a2cd).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21234      +/-   ##
==========================================
- Coverage   79.86%   79.79%   -0.08%     
==========================================
  Files        1593     1593              
  Lines      228268   228278      +10     
  Branches     2600     2600              
==========================================
- Hits       182311   182151     -160     
- Misses      45360    45530     +170     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants