Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(python): Avoid unnecessary packaging dependency #21223

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

alexander-beedie
Copy link
Collaborator

@alexander-beedie alexander-beedie commented Feb 12, 2025

Closes #21221.

Unnecessary import of the packaging module (inside write_delta()).
We can use our own parse_version() here to drop the dependency 👌

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Feb 12, 2025
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.69%. Comparing base (9bcff72) to head (ee76fb3).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/dataframe/frame.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21223      +/-   ##
==========================================
- Coverage   79.75%   79.69%   -0.07%     
==========================================
  Files        1593     1593              
  Lines      228119   228118       -1     
  Branches     2600     2600              
==========================================
- Hits       181947   181793     -154     
- Misses      45575    45728     +153     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-beedie alexander-beedie force-pushed the unnecessary-packaging-dep branch from 4d9d17f to ee76fb3 Compare February 13, 2025 12:12
@ritchie46 ritchie46 merged commit c3b7760 into pola-rs:main Feb 13, 2025
15 checks passed
@alexander-beedie alexander-beedie deleted the unnecessary-packaging-dep branch February 14, 2025 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'packaging'
2 participants