Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't take in rewriting visitor #21212

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat: Don't take in rewriting visitor #21212

merged 1 commit into from
Feb 12, 2025

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Feb 12, 2025
Copy link
Contributor

The uncompressed lib size after this PR is 39.7272 MB.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (f69768d) to head (c00519d).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21212      +/-   ##
==========================================
- Coverage   79.88%   79.88%   -0.01%     
==========================================
  Files        1593     1593              
  Lines      227803   227804       +1     
  Branches     2600     2600              
==========================================
- Hits       181989   181982       -7     
- Misses      45217    45225       +8     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ac86090 into main Feb 12, 2025
20 of 22 checks passed
@ritchie46 ritchie46 deleted the visitor branch February 12, 2025 11:53
braaannigan pushed a commit to braaannigan/polars that referenced this pull request Feb 12, 2025
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants