Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add sampling to new-streaming equi join to decide between build/probe side #21197

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 11, 2025

The new streaming engine's join will now buffer at least POLARS_JOIN_SAMPLE_LIMIT rows (default 10 million) from both sides of the join before deciding which side will become a build or probe side.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 326 lines in your changes missing coverage. Please review.

Project coverage is 79.78%. Comparing base (e8e0295) to head (ec1d5eb).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/joins/equi_join.rs 0.00% 309 Missing ⚠️
crates/polars-expr/src/hash_keys.rs 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21197      +/-   ##
==========================================
- Coverage   79.88%   79.78%   -0.11%     
==========================================
  Files        1593     1593              
  Lines      227649   228096     +447     
  Branches     2600     2600              
==========================================
+ Hits       181860   181980     +120     
- Misses      45192    45519     +327     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp marked this pull request as draft February 11, 2025 18:35
@orlp orlp marked this pull request as ready for review February 11, 2025 20:06
@ritchie46 ritchie46 merged commit af8d8d9 into pola-rs:main Feb 12, 2025
26 of 27 checks passed
braaannigan pushed a commit to braaannigan/polars that referenced this pull request Feb 12, 2025
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants