Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for fixed open issues #21185

Merged
merged 3 commits into from
Feb 15, 2025

Conversation

lukemanley
Copy link
Contributor

Tests added for open issues that appear to be fixed:

closes #15474
closes #15425
closes #14863
closes #10869

These issues appear to be fixed and tested (noting tests in order to close):

closes #19754 - test_join.py::test_join_on_struct
closes #17411 - test_list.py::test_list_arr_get
closes #14424 - test_sort.py::test_expr_sort_by_multi_nulls_last
closes #12530 - test_interop.py::test_df_pycapsule_interface
closes #7038 - test_csv.py::test_error_message

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (0654544) to head (b715c71).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21185   +/-   ##
=======================================
  Coverage   79.88%   79.88%           
=======================================
  Files        1593     1593           
  Lines      227754   227754           
  Branches     2600     2600           
=======================================
+ Hits       181937   181947   +10     
+ Misses      45220    45210   -10     
  Partials      597      597           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit db97383 into pola-rs:main Feb 15, 2025
10 of 14 checks passed
@lukemanley lukemanley deleted the test-fixed-issues branch February 15, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
2 participants