Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add row index to new streaming multiscan #21169

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 86.59218% with 24 lines in your changes missing coverage. Please review.

Project coverage is 79.88%. Comparing base (d15bfe5) to head (99856a6).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/io_sources/csv.rs 48.88% 23 Missing ⚠️
.../polars-stream/src/nodes/io_sources/parquet/mod.rs 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21169      +/-   ##
==========================================
- Coverage   79.88%   79.88%   -0.01%     
==========================================
  Files        1593     1593              
  Lines      227640   227752     +112     
  Branches     2600     2600              
==========================================
+ Hits       181856   181933      +77     
- Misses      45187    45222      +35     
  Partials      597      597              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit e143e7e into pola-rs:main Feb 11, 2025
27 checks passed
@coastalwhite coastalwhite deleted the perf/new-streaming-multiscan-rowcount branch February 11, 2025 12:01
braaannigan pushed a commit to braaannigan/polars that referenced this pull request Feb 12, 2025
@c-peters c-peters added the accepted Ready for implementation label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants