fix: Fix projection count query optimization #21162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
ritchie46
commented
Feb 10, 2025
| expr_arena: &mut Arena<AExpr>, | ||
| ) { | ||
| // if empty: all columns are already projected. | ||
| if !acc_projections.is_empty() && !projected_names.contains(&name) { | ||
| // if not pushed down: all columns are already projected. |
|
The uncompressed lib size after this PR is 39.7190 MB. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21162 +/- ##
==========================================
+ Coverage 79.81% 79.88% +0.07%
==========================================
Files 1593 1593
Lines 227649 227634 -15
Branches 2600 2600
==========================================
+ Hits 181699 181847 +148
+ Misses 45353 45190 -163
Partials 597 597 ☔ View full report in Codecov by Sentry. |
braaannigan
pushed a commit
to braaannigan/polars
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21154