Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 'allow_exact_matches' join_asof' #20723

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat: Add 'allow_exact_matches' join_asof' #20723

merged 1 commit into from
Jan 15, 2025

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jan 15, 2025

closes #15535
closes #7932

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jan 15, 2025
Copy link
Contributor

The uncompressed lib size after this PR is 39.2291 MB.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 82.81250% with 33 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (f3906ec) to head (1b254f9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-ops/src/frame/join/asof/groups.rs 69.76% 26 Missing ⚠️
crates/polars-ops/src/frame/join/asof/mod.rs 85.41% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #20723    +/-   ##
========================================
  Coverage   79.84%   79.84%            
========================================
  Files        1560     1560            
  Lines      221417   221539   +122     
  Branches     2530     2530            
========================================
+ Hits       176797   176898   +101     
- Misses      44038    44059    +21     
  Partials      582      582            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 46b2714 into main Jan 15, 2025
34 checks passed
@ritchie46 ritchie46 deleted the asof branch January 15, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
1 participant