Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add
list.pad_start()
#20674base: main
Are you sure you want to change the base?
feat: Add
list.pad_start()
#20674Changes from 30 commits
3e036c7
34486da
6b00202
aa9a5c2
73966bf
aa4fa4e
2f5e959
1181d73
64dd07f
e3c71bd
b36433a
b736ba6
1d022ab
4b897e5
823f5db
4de5381
46d5a75
7ed3aa4
92f55ab
352fbf6
f0e9150
3f7ca46
bad748f
b87cd9a
28b295d
3cb1871
56a6865
6b8e919
658347a
5d7fe4d
dbf9035
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find a way to pass this in
zip_and_apply_amortized()
, which is why I make it an iterator here and callnext()
insidezip_and_apply_amortized()
. It works but feels clunky.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entire
match
should probably be reduced by calling one function per datatype, which will be also used forlist.pad_end()
(in another PR).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, works but feels clunky.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
clone()
here ok or a no-go? If the latter, what is the alternative?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is wrong because the output dtype can change because the inner dtype and the padding type are cast to the supertype.
However, it does pass the tests. Why is that? Is there a test I can add for this?