Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix variable name in error message for "unsupported data type" in rolling and upsampling operations #20553

Merged

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Jan 3, 2025

closes #20081

Currently, the error message refers to window_size, but that's not correct, because ensure_duration_matches_dtype matches on the time/index column dtype

It's a little unfortunate that the name of this variable across operations:

  • upsample: time_column
  • rolling: index_column
  • rolling_*_by: by

but I think referring to "temporal/index column" should be enough to clear up the confusion

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (5f44997) to head (c2accef).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20553      +/-   ##
==========================================
- Coverage   79.04%   79.00%   -0.04%     
==========================================
  Files        1564     1564              
  Lines      220640   220619      -21     
  Branches     2502     2502              
==========================================
- Hits       174404   174308      -96     
- Misses      45662    45737      +75     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review January 3, 2025 22:06
@ritchie46 ritchie46 merged commit e360e0a into pola-rs:main Jan 5, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect error message raised for Polars.DataFrame.rolling: error is about index column not period
2 participants