fix: Fix variable name in error message for "unsupported data type" in rolling and upsampling operations #20553
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #20081
Currently, the error message refers to
window_size
, but that's not correct, becauseensure_duration_matches_dtype
matches on the time/index column dtypeIt's a little unfortunate that the name of this variable across operations:
upsample
:time_column
rolling
:index_column
rolling_*_by
:by
but I think referring to "temporal/index column" should be enough to clear up the confusion