Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Groundwork for allowing multi-output nodes in the new streaming engine #20550

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Jan 3, 2025

This does not yet allow a node with multiple output schemas, that will come in a follow-up PR.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 156 lines in your changes missing coverage. Please review.

Project coverage is 78.97%. Comparing base (da0b589) to head (c947568).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ates/polars-stream/src/physical_plan/lower_expr.rs 0.00% 73 Missing ⚠️
crates/polars-stream/src/physical_plan/mod.rs 0.00% 51 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 13 Missing ⚠️
crates/polars-stream/src/graph.rs 0.00% 9 Missing ⚠️
crates/polars-stream/src/execute.rs 0.00% 7 Missing ⚠️
crates/polars-stream/src/physical_plan/to_graph.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20550      +/-   ##
==========================================
- Coverage   79.00%   78.97%   -0.03%     
==========================================
  Files        1564     1564              
  Lines      220619   220704      +85     
  Branches     2502     2502              
==========================================
+ Hits       174300   174301       +1     
- Misses      45745    45829      +84     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp force-pushed the new-stream-multi-out branch from 82312da to c947568 Compare January 4, 2025 00:27
@ritchie46 ritchie46 merged commit 7fddd84 into pola-rs:main Jan 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants