build(python): Officially support Python 3.13 #20549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
|
The previous uncompressed lib size was Unknown MB. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20549 +/- ##
==========================================
- Coverage 79.05% 78.98% -0.08%
==========================================
Files 1564 1564
Lines 220627 220759 +132
Branches 2502 2504 +2
==========================================
- Hits 174413 174358 -55
- Misses 45640 45827 +187
Partials 574 574 ☔ View full report in Codecov by Sentry. |
stinodego
changed the title
stinodego
commented
Jan 5, 2025
| uv pip install -U typing-extensions | ||
| uv pip install --compile-bytecode -r requirements-dev.txt -r requirements-ci.txt --verbose | ||
| uv pip install -U typing-extensions | ||
| uv pip install --compile-bytecode -r requirements-dev.txt -r requirements-ci.txt --verbose --index-strategy=unsafe-best-match |
There was a problem hiding this comment.
The --extra-index-url https://download.pytorch.org/whl/cpu entry in requirements-ci.txt caueses issues for NumPy installation under Python 3.13. Specifying this index strategy makes it so that NumPy is downloaded from the regular PyPI registry rather than the PyTorch registry.
stinodego
changed the title
github-actions
bot
added
the
enhancement
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
stinodego
changed the title
stinodego
removed
the
enhancement
github-actions
bot
added
the
build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polars was already installable under Python 3.13 and already worked. This PR officially marks Python 3.13 as supported and updates our CI to also run tests under Python 3.13.
There's still some issue with the benchmark workflow due to the setup of our self-hosted runner. We can look into this later.
There's also an issue with running MyPy with the latest NumPy version that came up because of this PR. I made an issue for this: #20561