Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert categorical unique code #20540

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: Revert categorical unique code #20540

merged 1 commit into from
Jan 3, 2025

Conversation

ritchie46
Copy link
Member

fixes #20539

@ritchie46 ritchie46 changed the title fix: Revert to old unique code fix: Revert categorical unique code Jan 3, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (58c1745) to head (df9212d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20540      +/-   ##
==========================================
+ Coverage   79.04%   79.05%   +0.01%     
==========================================
  Files        1564     1564              
  Lines      220640   220627      -13     
  Branches     2502     2502              
==========================================
+ Hits       174413   174425      +12     
+ Misses      45653    45628      -25     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ca36b66 into main Jan 3, 2025
28 checks passed
@ritchie46 ritchie46 deleted the unique branch January 3, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using unique aggregations with StringCache replaces values with null
1 participant