Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix various Int128 operations #20515

Merged
merged 14 commits into from
Jan 2, 2025
Merged

Conversation

lukemanley
Copy link
Contributor

@lukemanley lukemanley commented Dec 31, 2024

Fixes the following operations for Int128:

  • abs
  • cum_prod
  • cum_sum
  • interpolate
  • product
  • rolling_map
  • eq
  • ne
  • ge
  • gt
  • le
  • lt

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 31, 2024
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (25fab78) to head (c768f30).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/expr/rolling.rs 62.50% 3 Missing ⚠️
crates/polars-plan/src/dsl/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20515      +/-   ##
==========================================
+ Coverage   79.04%   79.05%   +0.01%     
==========================================
  Files        1563     1563              
  Lines      220798   220813      +15     
  Branches     2502     2502              
==========================================
+ Hits       174521   174572      +51     
+ Misses      45703    45667      -36     
  Partials      574      574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jan 1, 2025

CodSpeed Performance Report

Merging #20515 will improve performances by 28.45%

Comparing lukemanley:fix-i128-ops (ed7043a) with main (25fab78)

Summary

⚡ 1 improvements
✅ 40 untouched benchmarks

Benchmarks breakdown

Benchmark main lukemanley:fix-i128-ops Change
test_to_numpy_series_with_nulls 410.6 µs 319.6 µs +28.45%

@ritchie46
Copy link
Member

Awesome! Thanks a lot @lukemanley!

@ritchie46 ritchie46 merged commit 11fa6de into pola-rs:main Jan 2, 2025
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants