Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix align_frames with single row panicking #20466

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

lukemanley
Copy link
Contributor

closes #20445

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 26, 2024
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.69%. Comparing base (0c290d6) to head (6d7f28f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...s/polars-ops/src/frame/join/dispatch_left_right.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #20466       +/-   ##
===========================================
- Coverage   78.98%   58.69%   -20.29%     
===========================================
  Files        1563     1563               
  Lines      220557   220555        -2     
  Branches     2488     2488               
===========================================
- Hits       174209   129463    -44746     
- Misses      45775    90519    +44744     
  Partials      573      573               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4c5fc38 into pola-rs:main Dec 27, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

align_frames regression: 1-row inputs with how="left" triggers panic
2 participants