Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return correct schema for sum_horizontal with boolean dtype #20459

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

mcrumiller
Copy link
Contributor

Fixes #20454

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.00%. Comparing base (a6fffd4) to head (75a3de4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20459   +/-   ##
=======================================
  Coverage   79.00%   79.00%           
=======================================
  Files        1563     1563           
  Lines      220449   220451    +2     
  Branches     2488     2488           
=======================================
+ Hits       174157   174167   +10     
+ Misses      45719    45711    -8     
  Partials      573      573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcrumiller mcrumiller marked this pull request as ready for review December 26, 2024 02:58
@ritchie46 ritchie46 merged commit 0d4f8e7 into pola-rs:main Dec 26, 2024
26 of 27 checks passed
@mcrumiller mcrumiller deleted the horz-sum-bool branch December 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

collect_schema returns incorrect dtype for boolean horizontal sum when first column is null
2 participants