Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Purge ChunkedArray Metadata #20371

Merged
merged 4 commits into from
Dec 20, 2024
Merged

perf: Purge ChunkedArray Metadata #20371

merged 4 commits into from
Dec 20, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Dec 19, 2024
@coastalwhite coastalwhite force-pushed the refactor/purge-ca-metadata branch from bd17052 to abe981c Compare December 19, 2024 16:29
@coastalwhite coastalwhite marked this pull request as draft December 19, 2024 16:32
@coastalwhite coastalwhite force-pushed the refactor/purge-ca-metadata branch from 11e510c to 4fc9755 Compare December 20, 2024 09:46
@coastalwhite coastalwhite force-pushed the refactor/purge-ca-metadata branch from 4fc9755 to bafceb3 Compare December 20, 2024 09:53
@coastalwhite coastalwhite marked this pull request as ready for review December 20, 2024 09:55
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.92271% with 25 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (6e4d717) to head (bafceb3).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/chunked_array/flags.rs 75.00% 17 Missing ⚠️
crates/polars-core/src/frame/mod.rs 0.00% 4 Missing ⚠️
crates/polars-core/src/frame/column/mod.rs 33.33% 2 Missing ⚠️
crates/polars-core/src/chunked_array/ops/nulls.rs 0.00% 1 Missing ⚠️
crates/polars-core/src/serde/chunked_array.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20371      +/-   ##
==========================================
+ Coverage   79.13%   79.14%   +0.01%     
==========================================
  Files        1572     1566       -6     
  Lines      219839   219231     -608     
  Branches     2462     2465       +3     
==========================================
- Hits       173970   173516     -454     
+ Misses      45301    45147     -154     
  Partials      568      568

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 changed the title refactor: Purge ChunkedArray Metadata perf: Purge ChunkedArray Metadata Dec 20, 2024
@github-actions github-actions bot added the performance Performance issues or improvements label Dec 20, 2024
@ritchie46 ritchie46 merged commit 5d2d550 into pola-rs:main Dec 20, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@coastalwhite coastalwhite

Labels
accepted Ready for implementation internal An internal refactor or improvement performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coastalwhite @ritchie46 @c-peters