Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect object store caching for ADLS URI #20357

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 19, 2024

Fixes #20347

# Before
# Parquet SCAN [abfss://account.dfs.core.windows.net/hive_date/date1=2024-01-01/date2=2023-01-01%2000%3A00%3A00.000000/ce0249bc8a1d412f87a7ca87977bd1f2-0.parquet, ... 3 other sources]
# After
# Parquet SCAN [abfss://bucket@account.dfs.core.windows.net/hive_date/date1=2024-01-01/date2=2023-01-01%2000%3A00%3A00.000000/ce0249bc8a1d412f87a7ca87977bd1f2-0.parquet, ... 3 other sources]

This also adds a step in build_azure that automatically looks for and uses the Azure storage account key if it can be found (using Azure CLI az storage account keys list --account-name ACCOUNT). For my local, this change makes it so that I no longer need to insert the account_key into the storage_options.

Other setups where using the Azure CLI is installed and prints There are no credentials provided in your command and environment, we will query for account key for your storage account., and then succeeds on storage operations should observe the same effect.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 27.08333% with 70 lines in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (6e4d717) to head (9b1bf26).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/cloud/options.rs 1.44% 68 Missing ⚠️
crates/polars-io/src/cloud/glob.rs 90.00% 1 Missing ⚠️
crates/polars-io/src/cloud/object_store_setup.rs 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20357      +/-   ##
==========================================
- Coverage   79.13%   79.11%   -0.03%     
==========================================
  Files        1572     1572              
  Lines      219839   219911      +72     
  Branches     2462     2462              
==========================================
+ Hits       173970   173974       +4     
- Misses      45301    45369      +68     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 19, 2024 09:00
@ritchie46 ritchie46 merged commit c56ecdf into pola-rs:main Dec 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect results using multiple buckets with Azure Data Lake Storage URI
2 participants