feat: Enable joins between compatible differing numeric key columns #20332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
nameexhaustion
changed the title
|
Nice, I think we should follow up with a |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20332 +/- ##
==========================================
+ Coverage 79.49% 79.50% +0.01%
==========================================
Files 1569 1569
Lines 218634 218782 +148
Branches 2462 2462
==========================================
+ Hits 173799 173953 +154
+ Misses 44267 44261 -6
Partials 568 568 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
commented
Dec 17, 2024
| let key_cols_coalesced = | ||
| options.args.should_coalesce() && matches!(&options.args.how, JoinType::Full); | ||
|
|
||
| if key_cols_coalesced { |
There was a problem hiding this comment.
I've made it so that we maintain the input column types in the output for all cases except for full-join with coalesce=True. Alternatively we could also just always use the supertype in the result.
There was a problem hiding this comment.
I think that what you did now is correct. 👍
nameexhaustion
changed the title
nameexhaustion
changed the title
nameexhaustion
changed the title
ritchie46
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joins between keys with differing numeric types now succeed if there is a compatible supertype to which both can be casted to without loss of information.
Fixes #15338