Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Don't warn on fork hook #20309

Merged
merged 2 commits into from
Dec 16, 2024
Merged

refactor: Don't warn on fork hook #20309

merged 2 commits into from
Dec 16, 2024

Conversation

ritchie46
Copy link
Member

fixes #20255

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Dec 16, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.61%. Comparing base (c4d0852) to head (1af3cae).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #20309   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files        1567     1567           
  Lines      218467   218453   -14     
  Branches     2465     2462    -3     
=======================================
- Hits       173929   173921    -8     
+ Misses      43969    43965    -4     
+ Partials      569      567    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ff95fad into main Dec 16, 2024
13 checks passed
@ritchie46 ritchie46 deleted the post branch December 16, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting warning message "Using fork() can cause Polars to deadlock in the child process"
1 participant
@ritchie46