fix: Fix error writing on Windows to locations outside of C drive #20245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Dec 10, 2024
| @@ -70,10 +70,13 @@ pub fn try_get_writeable( | |||
| } else { | |||
| let path = resolve_homedir(&path); | |||
| std::fs::File::create(&path).map_err(PolarsError::from)?; | |||
| let path = std::fs::canonicalize(&path)?; | |||
There was a problem hiding this comment.
we don't actually need to do this here, was copy pasted from force_async code
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20245 +/- ##
=======================================
Coverage 79.65% 79.65%
=======================================
Files 1565 1565
Lines 218201 218278 +77
Branches 2475 2475
=======================================
+ Hits 173799 173876 +77
Misses 43835 43835
Partials 567 567 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
ritchie46
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #20231. I couldn't reproduce the issue so this is just a guess based on the fact that we were apparently able to at least create the file.