Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(python): Add test for BytesIO overwritten after scan #20240

Merged
merged 1 commit into from
Dec 10, 2024
Merged

test(python): Add test for BytesIO overwritten after scan #20240

merged 1 commit into from
Dec 10, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 10, 2024 •
edited
Loading

Ensure that the LazyFrame is not affected by BytesIO being overwritten.

Also some refactor to reduce code duplication

@nameexhaustion nameexhaustion changed the title tests(python): Add test for BytesIO overwritten after scan test(python): Add test for BytesIO overwritten after scan Dec 10, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars and removed title needs formatting labels Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.64%. Comparing base (2c76494) to head (ccedbd2).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #20240      +/-   ##
==========================================
- Coverage   79.65%   79.64%   -0.01%     
==========================================
  Files        1565     1565              
  Lines      218202   218201       -1     
  Branches     2475     2475              
==========================================
- Hits       173804   173786      -18     
- Misses      43831    43848      +17     
  Partials      567      567

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 10, 2024 05:08
@ritchie46 ritchie46 merged commit c2ef569 into pola-rs:main Dec 10, 2024
27 of 28 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees

@nameexhaustion nameexhaustion

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nameexhaustion @ritchie46 @c-peters