fix: Fix assertion panic on LazyFrame scratch.is_empty()
#20219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nameexhaustion
changed the title
scratch.is_empty()
github-actions
bot
added
fix
nameexhaustion
force-pushed
the
slice-pd-panic
branch
from
63e073e to
a56c992
Compare
nameexhaustion
force-pushed
the
slice-pd-panic
branch
from
a56c992 to
0c5cf8f
Compare
nameexhaustion
commented
Dec 9, 2024
| @@ -25,6 +25,7 @@ mod inner { | |||
| } | |||
|
|
|||
| pub fn nodes_scratch_mut(&mut self) -> &mut UnitVec<Node> { | |||
| self.scratch.clear(); | |||
nameexhaustion
changed the title
scratch.is_empty()scratch.is_empty()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20219 +/- ##
=======================================
Coverage 79.62% 79.62%
=======================================
Files 1565 1565
Lines 218188 218192 +4
Branches 2475 2475
=======================================
+ Hits 173735 173744 +9
+ Misses 43886 43881 -5
Partials 567 567 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
nameexhaustion
commented
Dec 9, 2024
| @@ -49,7 +50,8 @@ fn can_pushdown_slice_past_projections( | |||
| arena: &Arena<AExpr>, | |||
| scratch: &mut UnitVec<Node>, | |||
| ) -> (bool, bool) { | |||
| assert!(scratch.is_empty()); | |||
| debug_assert!(scratch.is_empty()); | |||
| scratch.clear(); | |||
There was a problem hiding this comment.
make this only panic in debug builds, and in release we clear it
|
Ai, will patch this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20216