Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow sorting of lists and arrays #20169

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #17228.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (cbc0ea0) to head (8df9c3a).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...polars-core/src/chunked_array/ops/sort/arg_sort.rs 88.23% 2 Missing ⚠️
...es/polars-core/src/chunked_array/ops/row_encode.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20169      +/-   ##
==========================================
+ Coverage   79.58%   79.62%   +0.04%     
==========================================
  Files        1564     1564              
  Lines      217475   217765     +290     
  Branches     2472     2475       +3     
==========================================
+ Hits       173070   173392     +322     
+ Misses      43837    43804      -33     
- Partials      568      569       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 947bf89 into pola-rs:main Dec 6, 2024
22 of 23 checks passed
@coastalwhite coastalwhite deleted the feat/list-array-sort branch December 6, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sorting list-of-lists column
2 participants