fix: Incorrect aggregation of empty groups after slice #20127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
commented
Dec 3, 2024
| @@ -110,6 +110,11 @@ impl PhysicalExpr for SliceExpr { | |||
| .collect::<PolarsResult<Vec<_>>>() | |||
| })?; | |||
| let mut ac = results.pop().unwrap(); | |||
|
|
|||
| if ac.is_aggregated() { | |||
| polars_bail!(InvalidOperation: "cannot slice() an aggregated value") | |||
There was a problem hiding this comment.
drive-by - I noticed we currently silently ignore slice() after aggregations - I've made this raise instead.
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20127 +/- ##
==========================================
+ Coverage 79.52% 79.53% +0.01%
==========================================
Files 1563 1563
Lines 217184 217194 +10
Branches 2465 2465
==========================================
+ Hits 172706 172739 +33
+ Misses 43917 43894 -23
Partials 561 561 ☔ View full report in Codecov by Sentry. |
nameexhaustion
commented
Dec 3, 2024
| @@ -657,7 +657,8 @@ impl Column { | |||
| let mut s = scalar_col.take_materialized_series().rechunk(); | |||
| // SAFETY: We perform a compute_len afterwards. | |||
| let chunks = unsafe { s.chunks_mut() }; | |||
| chunks[0].with_validity(Some(validity)); | |||
There was a problem hiding this comment.
this function isn't in-place and we didn't assign back 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returned previously filtered values instead of NULL.
Fixes #20115