Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Replace custom PushNode trait with Extend #20107

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 2, 2024

Extend is available from std::iter

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.52%. Comparing base (58f763a) to head (9c75716).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20107      +/-   ##
==========================================
- Coverage   79.53%   79.52%   -0.01%     
==========================================
  Files        1563     1563              
  Lines      217115   217088      -27     
  Branches     2464     2464              
==========================================
- Hits       172679   172648      -31     
- Misses      43876    43880       +4     
  Partials      560      560              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 2, 2024 12:18
@ritchie46 ritchie46 merged commit e805487 into pola-rs:main Dec 2, 2024
22 checks passed
nimit pushed a commit to nimit/polars that referenced this pull request Dec 2, 2024
@c-peters c-peters added the accepted Ready for implementation label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants