feat: Add maintain_order parameter to joins
#20026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20026 +/- ##
==========================================
+ Coverage 79.54% 79.64% +0.10%
==========================================
Files 1564 1564
Lines 217211 217638 +427
Branches 2465 2475 +10
==========================================
+ Hits 172771 173342 +571
+ Misses 43879 43727 -152
- Partials 561 569 +8 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Nov 27, 2024
crates/polars-ops/src/frame/join/hash_join/single_keys_dispatch.rs
Outdated
Show resolved
Hide resolved
crates/polars-ops/src/frame/join/hash_join/single_keys_dispatch.rs
Outdated
Show resolved
Hide resolved
wence-
reviewed
Nov 29, 2024
stijnherfst
force-pushed
the
maintain-order
branch
from
41df7c2 to
b33ef3a
Compare
ritchie46
reviewed
Dec 3, 2024
| @@ -57,7 +57,7 @@ impl NodeTraverser { | |||
| // Increment major on breaking changes to the IR (e.g. renaming | |||
| // fields, reordering tuples), minor on backwards compatible | |||
| // changes (e.g. exposing a new expression node). | |||
| const VERSION: Version = (3, 2); | |||
| const VERSION: Version = (4, 0); | |||
There was a problem hiding this comment.
I don't think this is a breaking IR change, but a minor version bump.
There was a problem hiding this comment.
We changed the structure of the tuple in the join options (one more field)
stijnherfst
force-pushed
the
maintain-order
branch
from
42c249e to
1072cdc
Compare
stijnherfst
requested review from
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
reviewed
Dec 4, 2024
crates/polars-pipe/src/executors/sinks/joins/generic_probe_inner_left.rs
Outdated
Show resolved
Hide resolved
ritchie46
changed the title
maintain_order parameter to joins
|
Good stuff :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API docs specify the ordering for left joins as preserving the order of the left Dataframe. In some cases it can be useful to also have this property for other types of joins and in other cases having no required ordering can allow for performance optimizations.