build: Add windows-aarch64 to python binaries #19966
Conversation
github-actions
bot
added
build
| architecture: [x86-64, aarch64] | ||
| exclude: | ||
| - os: windows-32gb-ram | ||
| - os: windows-latest |
There was a problem hiding this comment.
Public windows runners now have 16GB RAM. Seems enough.
| matrix: | ||
| package: [polars, polars-lts-cpu, polars-u64-idx] | ||
| os: [ubuntu-latest, macos-13, windows-32gb-ram] | ||
| os: [ubuntu-latest, macos-13, windows-latest, windows-arm64-16gb] | ||
| architecture: [x86-64, aarch64] | ||
| exclude: | ||
| - os: windows-32gb-ram | ||
| - os: windows-latest | ||
| architecture: aarch64 | ||
| - os: windows-arm64-16gb | ||
| architecture: x86-64 |
There was a problem hiding this comment.
The following matrix is equivalent but a bit more readable (using include rather than exclude):
matrix:
package: [polars, polars-lts-cpu, polars-u64-idx]
os: [ubuntu-latest, macos-13]
architecture: [x86-64, aarch64]
include:
- os: windows-latest
architecture: x86-64
- os: windows-arm64-16gb
architecture: aarch64
There was a problem hiding this comment.
Don't we need to include all variants then? (E.g. is the exclude set not smaller than the include set?)
There was a problem hiding this comment.
I think it's correct... Not 100% sure (should test it out...). The docs are here:
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow#expanding-or-adding-matrix-configurations
There was a problem hiding this comment.
Right, I think you're right. I also do need to think harder with the include set. 😆
|
I will take it for a spin. 😎 |
This reverts commit 5e91e4c.
No description provided.