Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Rolling 'iter_lookbehind' breeze through duplicates #19922

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Nov 22, 2024

Adds a small branch that ensures we skip very expensive computations on duplicates.

closes #19912

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.38%. Comparing base (e9a66e3) to head (d7a3b13).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-time/src/windows/group_by.rs 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #19922       +/-   ##
===========================================
- Coverage   79.43%   59.38%   -20.06%     
===========================================
  Files        1554     1554               
  Lines      215609   215618        +9     
  Branches     2454     2454               
===========================================
- Hits       171272   128039    -43233     
- Misses      43778    87020    +43242     
  Partials      559      559               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ritchie46 ritchie46 merged commit 7b07c85 into main Nov 22, 2024
22 checks passed
@ritchie46 ritchie46 deleted the rolling branch November 22, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rolling is super slow on large dataset if not grouped first
1 participant