-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Speed up starts_with for small prefixes #19904
Merged
Merged
+60
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stijnherfst
requested review from
ritchie46,
orlp and
c-peters
as code owners
November 21, 2024 09:36
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
rust
Related to Rust Polars
labels
Nov 21, 2024
ritchie46
reviewed
Nov 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19904 +/- ##
==========================================
+ Coverage 79.40% 79.48% +0.07%
==========================================
Files 1550 1555 +5
Lines 214909 216170 +1261
Branches 2447 2454 +7
==========================================
+ Hits 170653 171815 +1162
- Misses 43699 43797 +98
- Partials 557 558 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ritchie46
reviewed
Nov 21, 2024
ritchie46
approved these changes
Nov 22, 2024
ritchie46
changed the title
feat(rust): Speed up starts_with for small prefixes
feat: Speed up starts_with for small prefixes
Nov 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The string view type has a small (4 or <12 bytes) prefix inlined that we can use for comparisons. From a small test this is about the same speed on a worst case (search prefix > 12 bytes, string not inlined) and more than twice as fast on a best case (string <12 bytes so entirely inlined).