-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(python): Replace spaces with to support showing multiple spaces in HTML repr #19783
fix(python): Replace spaces with to support showing multiple spaces in HTML repr #19783
Conversation
e0351a7
to
a3c0ece
Compare
a3c0ece
to
e775f89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19783 +/- ##
========================================
Coverage 79.55% 79.56%
========================================
Files 1544 1545 +1
Lines 213240 213442 +202
Branches 2441 2444 +3
========================================
+ Hits 169645 169815 +170
- Misses 43046 43077 +31
- Partials 549 550 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the test I wouldn't assert quite so much detail, in case other (unrelated) formatting/elements change in the future - just assert that the strings which should now contain
are all present in the html_repr output?
Aside from that minor nit, looks good to go 😎
I'm using a regex for it, which I've elaborated with a comment above because regex is like arcane magic when you don't write it yourself |
e95dfe6
to
d0e270b
Compare
Fixes #19665
Before:
After:
I've added a small unit test that checks for a right output for the repr in
test_repr_html.py
, not sure if it's the correct location. Please let me know.