Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Migrate polars-expr AggregationContext to use Column #19736

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Nov 12, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 82.28438% with 76 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (3cdb7c2) to head (01a4266).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/column/mod.rs 78.12% 21 Missing ⚠️
crates/polars-core/src/frame/column/series.rs 67.74% 10 Missing ⚠️
crates/polars-expr/src/expressions/mod.rs 83.33% 10 Missing ⚠️
crates/polars-core/src/frame/mod.rs 11.11% 8 Missing ⚠️
crates/polars-core/src/scalar/mod.rs 0.00% 6 Missing ⚠️
crates/polars-expr/src/expressions/apply.rs 82.14% 5 Missing ⚠️
crates/polars-core/src/frame/column/scalar.rs 0.00% 4 Missing ⚠️
crates/polars-expr/src/expressions/aggregation.rs 95.23% 3 Missing ⚠️
crates/polars-expr/src/expressions/column.rs 78.57% 3 Missing ⚠️
crates/polars-expr/src/expressions/group_iter.rs 85.71% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19736      +/-   ##
==========================================
- Coverage   79.73%   79.72%   -0.01%     
==========================================
  Files        1542     1544       +2     
  Lines      212223   212846     +623     
  Branches     2449     2441       -8     
==========================================
+ Hits       169216   169693     +477     
- Misses      42453    42604     +151     
+ Partials      554      549       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 058491f into pola-rs:main Nov 14, 2024
18 of 20 checks passed
@coastalwhite coastalwhite deleted the refactor/aggregation-context-column branch November 14, 2024 13:11
@c-peters c-peters added the accepted Ready for implementation label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants