fix: Fix validation for inner and left join when join_nulls unflaged #19698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barak1412
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
barak1412
commented
Nov 8, 2024
| @@ -44,6 +44,8 @@ pub(super) fn hash_join_tuples_inner<T, I>( | |||
| swapped: bool, | |||
| validate: JoinValidation, | |||
| join_nulls: bool, | |||
| // We should know the number of nulls to avoid extra calculation | |||
| build_null_count: usize, | |||
There was a problem hiding this comment.
I wasn't sure about adding this param, but I wanted to avoid performing another pass on all values to calculate it inside the function.
ritchie46
approved these changes
Nov 11, 2024
| @@ -44,6 +44,8 @@ pub(super) fn hash_join_tuples_inner<T, I>( | |||
| swapped: bool, | |||
| validate: JoinValidation, | |||
| join_nulls: bool, | |||
| // We should know the number of nulls to avoid extra calculation | |||
| build_null_count: usize, | |||
crates/polars-ops/src/frame/join/hash_join/single_keys_inner.rs
Outdated
Show resolved
Hide resolved
|
Thanks @barak1412. Looks great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19624.