Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove more @scalar-opt #19666

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

coastalwhite
Copy link
Collaborator

This is a continuation of #19660.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 61.61616% with 38 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (4b03406) to head (fce576f).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/frame/column/mod.rs 55.81% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19666      +/-   ##
==========================================
- Coverage   79.73%   79.72%   -0.02%     
==========================================
  Files        1541     1541              
  Lines      212227   212236       +9     
  Branches     2449     2449              
==========================================
- Hits       169226   169198      -28     
- Misses      42446    42483      +37     
  Partials      555      555              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite force-pushed the refactor/more-scalar-opt branch from 9f4f4c2 to fce576f Compare November 7, 2024 06:36
@coastalwhite coastalwhite marked this pull request as ready for review November 7, 2024 06:37
@ritchie46 ritchie46 merged commit a7672ac into pola-rs:main Nov 7, 2024
20 checks passed
@coastalwhite coastalwhite deleted the refactor/more-scalar-opt branch November 7, 2024 13:00
tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
@c-peters c-peters added the accepted Ready for implementation label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants