Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Delegate feature flags for polars-stream #19659

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Nov 6, 2024

We should do this instead of unconditionally enabling things.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Nov 6, 2024
@ritchie46 ritchie46 merged commit 04c4acb into pola-rs:main Nov 6, 2024
19 checks passed
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.73%. Comparing base (6b0a906) to head (29aec3a).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19659      +/-   ##
==========================================
- Coverage   79.86%   79.73%   -0.13%     
==========================================
  Files        1537     1541       +4     
  Lines      211923   212010      +87     
  Branches     2446     2446              
==========================================
- Hits       169249   169044     -205     
- Misses      42120    42412     +292     
  Partials      554      554              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
@c-peters c-peters added the accepted Ready for implementation label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants