Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Allow for arbitrary skips in Parquet Dictionary Decoding #19649

Merged
merged 11 commits into from
Nov 6, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Nov 5, 2024

This PR allows for skips in parquet dictionary encoded data. This saves a lot of work with queries that have slices or predicates on sorted columns. This also allows dispatching to faster kernels way more often.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Nov 5, 2024
@coastalwhite coastalwhite marked this pull request as ready for review November 6, 2024 11:17
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 57.43855% with 329 lines in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (0f64785) to head (d3094f5).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
...ialize/dictionary_encoded/optional_masked_dense.rs 11.29% 165 Missing ⚠️
...ialize/dictionary_encoded/required_masked_dense.rs 12.41% 127 Missing ⚠️
...c/arrow/read/deserialize/dictionary_encoded/mod.rs 90.41% 16 Missing ⚠️
...ars-parquet/src/parquet/encoding/hybrid_rle/mod.rs 84.78% 7 Missing ⚠️
crates/polars-arrow/src/bitmap/bitmask.rs 45.45% 6 Missing ⚠️
...ow/read/deserialize/dictionary_encoded/optional.rs 96.66% 5 Missing ⚠️
...ow/read/deserialize/dictionary_encoded/required.rs 95.31% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19649      +/-   ##
==========================================
- Coverage   79.92%   79.73%   -0.20%     
==========================================
  Files        1536     1541       +5     
  Lines      211686   212020     +334     
  Branches     2445     2446       +1     
==========================================
- Hits       169192   169044     -148     
- Misses      41939    42422     +483     
+ Partials      555      554       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b23da1f into pola-rs:main Nov 6, 2024
26 checks passed
@coastalwhite coastalwhite deleted the perf/pq-dict-skips branch November 6, 2024 16:12
tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
@c-peters c-peters added the accepted Ready for implementation label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants