Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix filter incorrectly pushed past struct unnest when unnested column name matches upper column name #19638

Merged
merged 4 commits into from
Nov 6, 2024
Merged

fix: Fix filter incorrectly pushed past struct unnest when unnested column name matches upper column name #19638

merged 4 commits into from
Nov 6, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #19632

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Nov 5, 2024
@nameexhaustion nameexhaustion changed the title fix: Fix filter incorrectly pushed past struct unnest if the inner column name matched input schema fix: Fix filter incorrectly pushed past struct unnest when the inner column name also existed on the outer frame Nov 5, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review November 5, 2024 07:36
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.93%. Comparing base (0f64785) to head (cd5655f).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #19638   +/-   ##
=======================================
  Coverage   79.92%   79.93%           
=======================================
  Files        1536     1536           
  Lines      211686   211689    +3     
  Branches     2445     2445           
=======================================
+ Hits       169192   169208   +16     
+ Misses      41939    41926   -13     
  Partials      555      555

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion changed the title fix: Fix filter incorrectly pushed past struct unnest when the inner column name also existed on the outer frame fix: Fix filter incorrectly pushed past struct unnest when unnested column name matches upper column name Nov 5, 2024
@ritchie46 ritchie46 merged commit 0ab5944 into pola-rs:main Nov 6, 2024
26 checks passed
tylerriccio33 pushed a commit to tylerriccio33/polars that referenced this pull request Nov 8, 2024
@nameexhaustion @tylerriccio33
fix: Fix filter incorrectly pushed past struct unnest when unnested c…
5b8c689 
…olumn name matches upper column name (pola-rs#19638)
@nameexhaustion nameexhaustion deleted the filter-pd-unnest branch November 18, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LazyFrame optimizer incorrectly reorders filter/unnest
2 participants
@nameexhaustion @ritchie46