fix: Parquet decoding of nested dictionary values #19605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
coastalwhite
commented
Nov 3, 2024
| @@ -147,18 +147,18 @@ def test_cse_9630() -> None: | |||
|
|
|||
| @pytest.mark.write_disk | |||
| def test_schema_row_index_cse() -> None: | |||
| csv_a = NamedTemporaryFile() # noqa: SIM115 | |||
There was a problem hiding this comment.
pass-by: this still threw an error on my ruff
coastalwhite
commented
Nov 3, 2024
| @@ -29,15 +29,15 @@ def test_count_csv(io_files_path: Path, path: str, n_rows: int) -> None: | |||
|
|
|||
| @pytest.mark.write_disk | |||
| def test_commented_csv() -> None: | |||
| csv_a = NamedTemporaryFile() # noqa: SIM115 | |||
There was a problem hiding this comment.
pass-by: still threw an error on my ruff
coastalwhite
commented
Nov 3, 2024
| @@ -42,10 +42,11 @@ def PortableTemporaryFile( | |||
| "errors": errors, | |||
| }, | |||
| ) | |||
| tmp = NamedTemporaryFile(**params) # noqa: SIM115 | |||
There was a problem hiding this comment.
pass-by: still threw an error
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19605 +/- ##
==========================================
+ Coverage 79.84% 79.85% +0.01%
==========================================
Files 1536 1536
Lines 211405 211375 -30
Branches 2445 2445
==========================================
+ Hits 168790 168791 +1
+ Misses 42060 42029 -31
Partials 555 555 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.