Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Changes for new benchmark setup #18427

Closed
wants to merge 23 commits into from
Closed

Conversation

r-brink
Copy link
Contributor

@r-brink r-brink commented Aug 28, 2024

Renaming elements in the Polars repository to reflect the changes in our new benchmarking set up.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Aug 28, 2024
Copy link

codspeed-hq bot commented Aug 28, 2024

CodSpeed Performance Report

Merging #18427 will not alter performance

Comparing r-brink:benchmark (7127d1d) with main (b2550a0)

Summary

✅ 15 untouched benchmarks

🆕 22 new benchmarks
⁉️ 22 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main r-brink:benchmark Change
🆕 test_pdsh_q1 N/A 16.1 ms N/A
🆕 test_pdsh_q10 N/A 6.4 ms N/A
🆕 test_pdsh_q11 N/A 3.8 ms N/A
🆕 test_pdsh_q12 N/A 6.2 ms N/A
🆕 test_pdsh_q13 N/A 9.6 ms N/A
🆕 test_pdsh_q14 N/A 2.4 ms N/A
🆕 test_pdsh_q15 N/A 2.6 ms N/A
🆕 test_pdsh_q16 N/A 7.4 ms N/A
🆕 test_pdsh_q17 N/A 6.7 ms N/A
🆕 test_pdsh_q18 N/A 11.5 ms N/A
🆕 test_pdsh_q19 N/A 7.7 ms N/A
🆕 test_pdsh_q2 N/A 3.4 ms N/A
🆕 test_pdsh_q20 N/A 6.1 ms N/A
🆕 test_pdsh_q21 N/A 216.7 ms N/A
🆕 test_pdsh_q22 N/A 6.9 ms N/A
🆕 test_pdsh_q3 N/A 6.1 ms N/A
🆕 test_pdsh_q4 N/A 5.2 ms N/A
🆕 test_pdsh_q5 N/A 4.8 ms N/A
🆕 test_pdsh_q6 N/A 2 ms N/A
🆕 test_pdsh_q7 N/A 9.3 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@r-brink r-brink marked this pull request as ready for review August 28, 2024 11:39
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.88%. Comparing base (37a492e) to head (7127d1d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18427      +/-   ##
==========================================
- Coverage   79.92%   79.88%   -0.04%     
==========================================
  Files        1495     1496       +1     
  Lines      200279   200364      +85     
  Branches     2867     2867              
==========================================
- Hits       160081   160069      -12     
- Misses      39652    39749      +97     
  Partials      546      546              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@ritchie46
Copy link
Member

@r-brink can you rebase?

@r-brink r-brink requested a review from coastalwhite as a code owner August 29, 2024 14:29
@ritchie46
Copy link
Member

Can you open a new PR? 🙈

@ritchie46 ritchie46 closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants