fix(python): Don't enforce row order in join test results where not guaranteed #17596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17596 +/- ##
==========================================
- Coverage 80.45% 80.44% -0.02%
==========================================
Files 1484 1484
Lines 195594 195594
Branches 2778 2778
==========================================
- Hits 157368 157340 -28
- Misses 37714 37742 +28
Partials 512 512 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Polars team, while working on the GPU backend I encountered a few join tests that seem to rely on the order of rows returned by the join to pass, where the docs only indicate a particular ordering for left joins. This PR proposes some minor changes to the py-polars test suite that drop this as a pass condition in the places I encountered it. Hopefully I've not missed any obvious ones here, let me know if so.