Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix struct outer validity;fmt;is_in;cast;cmp #17590

Merged
merged 6 commits into from
Jul 12, 2024
Merged

refactor: Fix struct outer validity;fmt;is_in;cast;cmp #17590

merged 6 commits into from
Jul 12, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jul 12, 2024
@ritchie46 ritchie46 changed the title refactor: Fix struct outer validity;fmt;is_in;cast refactor: Fix struct outer validity;fmt;is_in;cast;cmp Jul 12, 2024
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (a098ed1) to head (81a7096).
Report is 1 commits behind head on main.

Files Patch % Lines
...ates/polars-core/src/chunked_array/ops/downcast.rs 90.32% 3 Missing ⚠️
...rates/polars-core/src/chunked_array/struct_/mod.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17590      +/-   ##
==========================================
+ Coverage   80.44%   80.47%   +0.03%     
==========================================
  Files        1484     1484              
  Lines      195532   195647     +115     
  Branches     2778     2780       +2     
==========================================
+ Hits       157299   157452     +153     
+ Misses      37721    37683      -38     
  Partials      512      512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f61af0f into main Jul 12, 2024
25 checks passed
@ritchie46 ritchie46 deleted the struct branch July 12, 2024 13:54
@c-peters c-peters added the accepted Ready for implementation label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants