Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix retries parameter in scan functions not taking effect when it was set to 0 #17564

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jul 11, 2024

I ran into this while writing tests for #17532

Changes

  • Set default retries to 2 to align with the Rust side
  • Make sure setting retries=0 works correctly

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Jul 11, 2024
@stinodego stinodego marked this pull request as ready for review July 11, 2024 06:57
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.54%. Comparing base (a55d9bc) to head (1ca685d).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/src/lazyframe/mod.rs 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17564      +/-   ##
==========================================
+ Coverage   80.49%   80.54%   +0.04%     
==========================================
  Files        1483     1483              
  Lines      195171   195189      +18     
  Branches     2778     2778              
==========================================
+ Hits       157099   157210     +111     
+ Misses      37561    37468      -93     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1108eff into main Jul 11, 2024
27 checks passed
@ritchie46 ritchie46 deleted the fix-retries branch July 11, 2024 13:46
@c-peters c-peters added the accepted Ready for implementation label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation fix Bug fix python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants