Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Raise if join keys are passed to cross join #17305

Merged
merged 1 commit into from
Jun 30, 2024
Merged

fix: Raise if join keys are passed to cross join #17305

merged 1 commit into from
Jun 30, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jun 30, 2024 •
edited
Loading

closes #17303

@codecov Codecov
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.72%. Comparing base (0c80788) to head (d41fb6f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #17305    +/-   ##
========================================
  Coverage   80.71%   80.72%            
========================================
  Files        1475     1475            
  Lines      193125   193238   +113     
  Branches     2757     2760     +3     
========================================
+ Hits       155882   155989   +107     
- Misses      36733    36739     +6     
  Partials      510      510

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 changed the title raise if keys passed to cross join fix: raise if keys passed to cross join Jun 30, 2024
@ritchie46 ritchie46 merged commit 59d2529 into main Jun 30, 2024
30 checks passed
@ritchie46 ritchie46 deleted the raise branch June 30, 2024 13:09
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jun 30, 2024
@stinodego stinodego changed the title fix: raise if keys passed to cross join fix: Raise if join keys are passed to cross join Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

@orlp orlp Awaiting requested review from orlp orlp is a code owner

Assignees
No one assigned
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cross-join should not work on any key
1 participant
@ritchie46