feat: Implement serde for Null columns #17218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
stinodego
commented
Jun 26, 2024
| let mut state = serializer.serialize_map(Some(3))?; | ||
| state.serialize_entry("name", self.name())?; | ||
| state.serialize_entry("datatype", self.dtype())?; | ||
| state.serialize_entry("values", &IterSer::new(std::iter::once(self.len())))?; |
There was a problem hiding this comment.
It feels slightly hacky to encode the length under "values", but hey... it works!
There was a problem hiding this comment.
Luckily we don't serialize to human readable anymore. 😉
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17218 +/- ##
==========================================
+ Coverage 80.81% 80.83% +0.01%
==========================================
Files 1466 1466
Lines 192229 192249 +20
Branches 2745 2745
==========================================
+ Hits 155355 155403 +48
+ Misses 36371 36343 -28
Partials 503 503 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously unimplemented, which led to a panic. Now it works!