perf: Improve unique
performance by adding RangedUniqueKernel for primitive arrays
#17166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unique value kernel that is selected based on the metadata for
PrimitiveArray
. When the difference between the metadata min and max value is small enough a different kernel is used that does not require sorting the data first.This is mostly to show how the new metadata can be used to select a different kernel.
For a microbenchmark on release mode, we see the following results:
This is a ~4.9x improvement. I feel like this can also be further improved if needed.