Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): Use AsRef<Path> instead of PathBuf in sink_ methods #17150

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

datapythonista
Copy link
Contributor

I guess there is no reason why something like shouldn't work:

ldf.sink_parquet("foo.parquet");

@stinodego stinodego changed the title Use AsRef<Path> instead of PathBuf in sink_ methods feat(rust): Use AsRef<Path> instead of PathBuf in sink_ methods Jun 23, 2024
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars labels Jun 23, 2024
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.88%. Comparing base (3444f64) to head (ca9470b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17150      +/-   ##
==========================================
- Coverage   80.88%   80.88%   -0.01%     
==========================================
  Files        1456     1456              
  Lines      191333   191337       +4     
  Branches     2742     2742              
==========================================
+ Hits       154757   154759       +2     
- Misses      36067    36069       +2     
  Partials      509      509              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

No reason. ;)

@ritchie46 ritchie46 merged commit 0b1f5ec into pola-rs:main Jun 24, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants